From: Simon Pilgrim Date: Sun, 13 Jun 2021 15:49:40 +0000 (+0100) Subject: DetailedRecordsBackend.cpp - printSectionHeading - avoid std::string creation/copies. X-Git-Tag: llvmorg-14-init~4103 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d1b57086d55afcfa94711a0b09c22a4113f6261f;p=platform%2Fupstream%2Fllvm.git DetailedRecordsBackend.cpp - printSectionHeading - avoid std::string creation/copies. Don't create std::string from constant c-strings or pass std::string by value - we can use StringRef instead. --- diff --git a/llvm/lib/TableGen/DetailedRecordsBackend.cpp b/llvm/lib/TableGen/DetailedRecordsBackend.cpp index c336a91..e181f79 100644 --- a/llvm/lib/TableGen/DetailedRecordsBackend.cpp +++ b/llvm/lib/TableGen/DetailedRecordsBackend.cpp @@ -45,7 +45,7 @@ public: void printVariables(raw_ostream &OS); void printClasses(raw_ostream &OS); void printRecords(raw_ostream &OS); - void printSectionHeading(std::string Title, int Count, raw_ostream &OS); + void printSectionHeading(StringRef Title, int Count, raw_ostream &OS); void printDefms(Record *Rec, raw_ostream &OS); void printTemplateArgs(Record *Rec, raw_ostream &OS); void printSuperclasses(Record *Rec, raw_ostream &OS); @@ -113,7 +113,7 @@ void DetailedRecordsEmitter::printRecords(raw_ostream &OS) { // Print a section heading with the name of the section and // the item count. -void DetailedRecordsEmitter::printSectionHeading(std::string Title, int Count, +void DetailedRecordsEmitter::printSectionHeading(StringRef Title, int Count, raw_ostream &OS) { OS << formatv("\n{0} {1} ({2}) {0}\n", "--------------------", Title, Count); }