From: Wan Jiabing Date: Mon, 18 Oct 2021 01:32:32 +0000 (-0400) Subject: net: mscc: ocelot: Add of_node_put() before goto X-Git-Tag: accepted/tizen/unified/20230118.172025~6147^2~23 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d1a7b9e4696584ce05c12567762c18a866837a85;p=platform%2Fkernel%2Flinux-rpi.git net: mscc: ocelot: Add of_node_put() before goto Fix following coccicheck warning: ./drivers/net/ethernet/mscc/ocelot_vsc7514.c:946:1-33: WARNING: Function for_each_available_child_of_node should have of_node_put() before goto. Early exits from for_each_available_child_of_node should decrement the node reference counter. Signed-off-by: Wan Jiabing Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/mscc/ocelot_vsc7514.c b/drivers/net/ethernet/mscc/ocelot_vsc7514.c index 291ae68..d51f799 100644 --- a/drivers/net/ethernet/mscc/ocelot_vsc7514.c +++ b/drivers/net/ethernet/mscc/ocelot_vsc7514.c @@ -969,6 +969,7 @@ static int mscc_ocelot_init_ports(struct platform_device *pdev, target = ocelot_regmap_init(ocelot, res); if (IS_ERR(target)) { err = PTR_ERR(target); + of_node_put(portnp); goto out_teardown; }