From: Sandeep Sharma <sandeep.s9@samsung.com>
Date: Wed, 11 Apr 2018 09:41:01 +0000 (+0530)
Subject: Fix coverity defects of maps-service
X-Git-Tag: submit/tizen/20180417.045714^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d1a737a3452d67ad9eb649c9fa94e607cf6d0167;p=platform%2Fcore%2Fapi%2Fmaps-service.git

Fix coverity defects of maps-service

Change-Id: Ia11bc6579928efffd559356def071da3376d04b6
Signed-off-by: Susnata <s.sovalin@samsung.com>
---

diff --git a/src/api/maps_extra_types.cpp b/src/api/maps_extra_types.cpp
index 27d3e19..b7e7081 100644
--- a/src/api/maps_extra_types.cpp
+++ b/src/api/maps_extra_types.cpp
@@ -341,8 +341,10 @@ EXPORT_API int maps_string_hashtable_foreach(maps_string_hashtable_h table,
 			continue; //LCOV_EXCL_LINE
 		char *value_clone = NULL;
 		if (maps_item_hashtable_clone_string(value,
-				(void **) &value_clone) != MAPS_ERROR_NONE)
+				(void **) &value_clone) != MAPS_ERROR_NONE) {
+			g_free(key_clone);
 			continue; //LCOV_EXCL_LINE
+		}
 
 		if (!callback(index++, total, key_clone, value_clone,
 				user_data))
@@ -892,9 +894,10 @@ EXPORT_API int maps_item_hashtable_foreach(maps_item_hashtable_h table,
 			continue;
 		void *value_clone = NULL;
 		if (item->clone_func(item->value,
-				&value_clone) != MAPS_ERROR_NONE)
+				&value_clone) != MAPS_ERROR_NONE) {
+			g_free(key_clone);
 			continue;
-
+		}
 		if (!callback(index++, total, key_clone, value_clone,
 				user_data))
 			break;
diff --git a/src/plugin/discovery.cpp b/src/plugin/discovery.cpp
index f2d60e0..a7698d5 100644
--- a/src/plugin/discovery.cpp
+++ b/src/plugin/discovery.cpp
@@ -137,7 +137,7 @@ plugin::provider_info plugin::find_by_names(const string &provider)
 
 void plugin::split_provider_name(const char *original, char **provider, char **module)
 {
-	char *save, *_provider, *_module;
+	char *save = NULL, *_provider = NULL, *_module = NULL;
 
 	_provider = strtok_r(g_strdup(original), "/", &save);
 	_module = g_strdup(strtok_r(NULL, "", &save));