From: Carsten Haitzler (Rasterman) <raster@rasterman.com>
Date: Sat, 6 Aug 2016 00:51:10 +0000 (+0900)
Subject: eina threadqueue - for paranoia lock+ulock+free in order locks taken
X-Git-Tag: upstream/1.20.0~4906
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d19cd4e63caf461e28fb536968f82e0d8a365cdc;p=platform%2Fupstream%2Fefl.git

eina threadqueue - for paranoia lock+ulock+free in order locks taken

so mimic order of locks taken to be paranoid ... this wouldnt be a
deadlock issue but just to be safe instead of sorry.
---

diff --git a/src/lib/eina/eina_thread_queue.c b/src/lib/eina/eina_thread_queue.c
index d5bee95..c76a5cb 100644
--- a/src/lib/eina/eina_thread_queue.c
+++ b/src/lib/eina/eina_thread_queue.c
@@ -137,14 +137,14 @@ _eina_thread_queue_msg_block_new(int size)
 static void
 _eina_thread_queue_msg_block_real_free(Eina_Thread_Queue_Msg_Block *blk)
 {
-   eina_lock_take(&(blk->lock_non_0_ref));
-   eina_lock_release(&(blk->lock_non_0_ref));
-   eina_lock_free(&(blk->lock_non_0_ref));
 #ifndef ATOMIC
    eina_lock_take(&(blk->lock_ref));
    eina_lock_release(&(blk->lock_ref));
    eina_spinlock_free(&(blk->lock_ref));
 #endif
+   eina_lock_take(&(blk->lock_non_0_ref));
+   eina_lock_release(&(blk->lock_non_0_ref));
+   eina_lock_free(&(blk->lock_non_0_ref));
    free(blk);
 }