From: Eran Ben Elisha Date: Tue, 24 Mar 2020 13:04:26 +0000 (+0200) Subject: net/mlx5e: Add missing release firmware call X-Git-Tag: v5.15~4044^2~37^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d19987ccf57501894fdd8fadc2e55e4a3dd57239;p=platform%2Fkernel%2Flinux-starfive.git net/mlx5e: Add missing release firmware call Once driver finishes flashing the firmware image, it should release it. Fixes: 9c8bca2637b8 ("mlx5: Move firmware flash implementation to devlink") Signed-off-by: Eran Ben Elisha Reviewed-by: Aya Levin Signed-off-by: Saeed Mahameed --- diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c index bdeb291..e94f0c4 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c @@ -23,7 +23,10 @@ static int mlx5_devlink_flash_update(struct devlink *devlink, if (err) return err; - return mlx5_firmware_flash(dev, fw, extack); + err = mlx5_firmware_flash(dev, fw, extack); + release_firmware(fw); + + return err; } static u8 mlx5_fw_ver_major(u32 version)