From: Karmjit Mahil Date: Fri, 14 Oct 2022 12:25:46 +0000 (+0100) Subject: pvr: Fix overflow before widen warning for rgn headers size calculation. X-Git-Tag: upstream/22.3.5~1480 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d19835e43cdba8c122b7a27174c63772834bb1f2;p=platform%2Fupstream%2Fmesa.git pvr: Fix overflow before widen warning for rgn headers size calculation. This fixes CID 1515968. Signed-off-by: Karmjit Mahil Reviewed-by: Frank Binns Part-of: --- diff --git a/src/imagination/vulkan/pvr_job_render.c b/src/imagination/vulkan/pvr_job_render.c index 1526a4d..6649759 100644 --- a/src/imagination/vulkan/pvr_job_render.c +++ b/src/imagination/vulkan/pvr_job_render.c @@ -587,8 +587,10 @@ static void pvr_rt_get_region_headers_stride_size( num_tiles_x = mtile_info->mtiles_x * mtile_info->tiles_per_mtile_x; num_tiles_y = mtile_info->mtiles_y * mtile_info->tiles_per_mtile_y; - rgn_headers_size = - (num_tiles_x / group_size) * (num_tiles_y / group_size) * rgn_header_size; + rgn_headers_size = (uint64_t)num_tiles_x / group_size; + /* Careful here. We want the division to happen first. */ + rgn_headers_size *= num_tiles_y / group_size; + rgn_headers_size *= rgn_header_size; if (PVR_HAS_FEATURE(dev_info, simple_internal_parameter_format)) { rgn_headers_size =