From: Emilio López Date: Sat, 25 Jan 2014 01:32:41 +0000 (-0300) Subject: clk: sunxi: fix overflow when setting up divided factors X-Git-Tag: v3.14-rc1~68^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d1933689aa9ce2e07fe9e7e2ff77358f8bb11864;p=kernel%2Fkernel-generic.git clk: sunxi: fix overflow when setting up divided factors Currently, we are allocating space for two pointers, when we actually may need to store three of them (two divisors plus the original clock). Fix this, and change sizeof(type) to sizeof(*var) to keep checkpatch.pl happy. Reported-by: Dan Carpenter Signed-off-by: Emilio López Signed-off-by: Mike Turquette --- diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c index 659e4ea..abb6c5a 100644 --- a/drivers/clk/sunxi/clk-sunxi.c +++ b/drivers/clk/sunxi/clk-sunxi.c @@ -875,7 +875,7 @@ static void __init sunxi_divs_clk_setup(struct device_node *node, if (!clk_data) return; - clks = kzalloc(SUNXI_DIVS_MAX_QTY * sizeof(struct clk *), GFP_KERNEL); + clks = kzalloc((SUNXI_DIVS_MAX_QTY+1) * sizeof(*clks), GFP_KERNEL); if (!clks) goto free_clkdata;