From: Justin Lebar Date: Sat, 13 Aug 2016 00:04:12 +0000 (+0000) Subject: [LSV] Use a set rather than an ArraySlice at the end of getVectorizablePrefix. NFC X-Git-Tag: llvmorg-4.0.0-rc1~12527 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d1675aadf6c730133f82288553d1e22f8313ff79;p=platform%2Fupstream%2Fllvm.git [LSV] Use a set rather than an ArraySlice at the end of getVectorizablePrefix. NFC Summary: This avoids a small O(n^2) loop. Reviewers: asbirlea Subscribers: mzolotukhin, llvm-commits, arsenm Differential Revision: https://reviews.llvm.org/D23473 llvm-svn: 278581 --- diff --git a/llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp b/llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp index 458d144..9fd0b8c 100644 --- a/llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp +++ b/llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp @@ -516,12 +516,11 @@ Vectorizer::getVectorizablePrefix(ArrayRef Chain) { // ChainInstrs[0, ChainInstrIdx). This is the largest vectorizable prefix of // Chain. (Recall that Chain is in address order, but ChainInstrs is in BB // order.) - auto VectorizableChainInstrs = - makeArrayRef(ChainInstrs.data(), ChainInstrIdx); - unsigned ChainIdx, ChainLen; - for (ChainIdx = 0, ChainLen = Chain.size(); ChainIdx < ChainLen; ++ChainIdx) { - Instruction *I = Chain[ChainIdx]; - if (!is_contained(VectorizableChainInstrs, I)) + SmallPtrSet VectorizableChainInstrs( + ChainInstrs.begin(), ChainInstrs.begin() + ChainInstrIdx); + unsigned ChainIdx = 0; + for (unsigned ChainLen = Chain.size(); ChainIdx < ChainLen; ++ChainIdx) { + if (!VectorizableChainInstrs.count(Chain[ChainIdx])) break; } return Chain.slice(0, ChainIdx);