From: Shawn Lin Date: Fri, 2 Sep 2016 04:14:38 +0000 (+0800) Subject: mmc: dw_mmc: fix misleading error print if failing to do DMA transfer X-Git-Tag: v4.14-rc1~2371^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d12d0cb1d7dc00605112bf1d5dcc157f2908a068;p=platform%2Fkernel%2Flinux-rpi.git mmc: dw_mmc: fix misleading error print if failing to do DMA transfer The original log didn't figure out that we could still finish this transfer by PIO mode even if failing to use DMA. And it should be kept for debug level instead of error one. Signed-off-by: Shawn Lin Signed-off-by: Jaehoon Chung Signed-off-by: Ulf Hansson --- diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 38099ba..c59a7b5 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -1057,8 +1057,10 @@ static int dw_mci_submit_data_dma(struct dw_mci *host, struct mmc_data *data) spin_unlock_irqrestore(&host->irq_lock, irqflags); if (host->dma_ops->start(host, sg_len)) { - /* We can't do DMA */ - dev_err(host->dev, "%s: failed to start DMA.\n", __func__); + /* We can't do DMA, try PIO for this one */ + dev_dbg(host->dev, + "%s: fall back to PIO mode for current transfer\n", + __func__); return -ENODEV; }