From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 7 Jan 2016 19:07:44 +0000 (+0100)
Subject: shared: simplify dns_name_hash_func() end of name detection
X-Git-Tag: v231~792^2~28
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d12315a4c883af968ec5ffb36a5aed3dc43b7ce7;p=platform%2Fupstream%2Fsystemd.git

shared: simplify dns_name_hash_func() end of name detection
---

diff --git a/src/shared/dns-domain.c b/src/shared/dns-domain.c
index 729508e..bcfc936 100644
--- a/src/shared/dns-domain.c
+++ b/src/shared/dns-domain.c
@@ -486,13 +486,15 @@ void dns_name_hash_func(const void *s, struct siphash *state) {
 
         assert(p);
 
-        while (*p) {
+        for (;;) {
                 char label[DNS_LABEL_MAX+1];
                 int k;
 
                 r = dns_label_unescape(&p, label, sizeof(label));
                 if (r < 0)
                         break;
+                if (r == 0)
+                        break;
 
                 k = dns_label_undo_idna(label, r, label, sizeof(label));
                 if (k < 0)
@@ -500,9 +502,6 @@ void dns_name_hash_func(const void *s, struct siphash *state) {
                 if (k > 0)
                         r = k;
 
-                if (r == 0)
-                        break;
-
                 ascii_strlower_n(label, r);
                 siphash24_compress(label, r, state);
         }