From: Qu Wenruo Date: Wed, 11 Feb 2015 01:57:17 +0000 (+0800) Subject: btrfs-progs: Fix 2 extent buffer leak in btrfs-debug-tree X-Git-Tag: upstream/4.16.1~2369 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d09504edb148336893d2a67c4cceb09b640ade14;p=platform%2Fupstream%2Fbtrfs-progs.git btrfs-progs: Fix 2 extent buffer leak in btrfs-debug-tree There are 2 known extent buffer leaks: 1) With -t option. -t option will skip other tree roots, but it will read the root node first and then skip it. Where it forgets to free the tree block it read. 2) with -b option. It forgets to free the tree block it read. Signed-off-by: Qu Wenruo Signed-off-by: David Sterba --- diff --git a/btrfs-debug-tree.c b/btrfs-debug-tree.c index ce7a792..610624e 100644 --- a/btrfs-debug-tree.c +++ b/btrfs-debug-tree.c @@ -221,6 +221,7 @@ int main(int ac, char **av) goto close_root; } btrfs_print_tree(root, leaf, 0); + free_extent_buffer(leaf); goto close_root; } @@ -284,8 +285,10 @@ again: 0); if (!extent_buffer_uptodate(buf)) goto next; - if (tree_id && found_key.objectid != tree_id) + if (tree_id && found_key.objectid != tree_id) { + free_extent_buffer(buf); goto next; + } switch(found_key.objectid) { case BTRFS_ROOT_TREE_OBJECTID: