From: Daniel Mack Date: Fri, 11 Jun 2010 15:34:19 +0000 (+0200) Subject: ALSA: usb-audio: add check for faulty clock in parse_audio_format_rates_v2() X-Git-Tag: v3.0~4272^2^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d07140ba7fe1b41713627c6dc3f169a00019fb0e;p=platform%2Fkernel%2Flinux-amlogic.git ALSA: usb-audio: add check for faulty clock in parse_audio_format_rates_v2() Signed-off-by: Daniel Mack Signed-off-by: Takashi Iwai --- diff --git a/sound/usb/format.c b/sound/usb/format.c index 5367cd1..df5b29f 100644 --- a/sound/usb/format.c +++ b/sound/usb/format.c @@ -218,6 +218,12 @@ static int parse_audio_format_rates_v2(struct snd_usb_audio *chip, int i, nr_rates, data_size, ret = 0; int clock = snd_usb_clock_find_source(chip, chip->ctrl_intf, fp->clock); + if (clock < 0) { + snd_printk(KERN_ERR "%s(): unable to find clock source (clock %d)\n", + __func__, clock); + goto err; + } + /* get the number of sample rates first by only fetching 2 bytes */ ret = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), UAC2_CS_RANGE, USB_TYPE_CLASS | USB_RECIP_INTERFACE | USB_DIR_IN,