From: ol.beketov
Date: Thu, 4 May 2017 13:42:08 +0000 (+0300)
Subject: [IOT-2092] Check null pointer before dereference
X-Git-Tag: 1.3.0~158
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d018476757e503b614d56f942132dd7c3801c1bb;p=platform%2Fupstream%2Fiotivity.git
[IOT-2092] Check null pointer before dereference
Change-Id: Ib8032c41e8910087be5c5b30fee9a7b4a3992f01
Signed-off-by: ol.beketov
Reviewed-on: https://gerrit.iotivity.org/gerrit/19623
Tested-by: jenkins-iotivity
Reviewed-by: Dan Mihai
Reviewed-by: Andrii Shtompel
Reviewed-by: Randeep Singh
---
diff --git a/plugins/zigbee_wrapper/telegesis_wrapper/src/telegesis_socket.c b/plugins/zigbee_wrapper/telegesis_wrapper/src/telegesis_socket.c
index 877cf06..a42926d 100644
--- a/plugins/zigbee_wrapper/telegesis_wrapper/src/telegesis_socket.c
+++ b/plugins/zigbee_wrapper/telegesis_wrapper/src/telegesis_socket.c
@@ -475,11 +475,10 @@ TWResultCode TWRetrieveEUI(PIPlugin_Zigbee * plugin, TWSock * twSock)
entry = readEntry(twSock->fd);
if(!entry)
{
- result = TWReleaseMutex(&twSock->mutex);
- if(result != TW_RESULT_OK)
- {
- goto exit;
- }
+ TWReleaseMutex(&twSock->mutex);
+ // in case entry is NULL, further processing will cause crash or UB
+ result = TW_RESULT_ERROR;
+ goto exit;
}
twSock->eui = (char *) OICMalloc(strlen(entry->lines[0].line)+1);
if(!twSock->eui)