From: Alex Deucher Date: Mon, 30 Nov 2020 23:12:27 +0000 (-0500) Subject: drm/amdgpu/powerplay/ci: return an error if copying to smc fails X-Git-Tag: v5.15~2259^2^2~57 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cfcc59d4c1af761a262c38e5bb65a4d631e1e9c6;p=platform%2Fkernel%2Flinux-starfive.git drm/amdgpu/powerplay/ci: return an error if copying to smc fails Rather than just silently dropping it. Also fixes a set but unused variable warning. Reviewed-by: Evan Quan Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c b/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c index 329bf4d..93a1c72 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c @@ -2193,7 +2193,7 @@ static int ci_thermal_setup_fan_table(struct pp_hwmgr *hwmgr) res = ci_copy_bytes_to_smc(hwmgr, ci_data->fan_table_start, (uint8_t *)&fan_table, (uint32_t)sizeof(fan_table), SMC_RAM_END); - return 0; + return res; } static int ci_program_mem_timing_parameters(struct pp_hwmgr *hwmgr)