From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 12 Jan 2022 11:17:24 +0000 (+0300)
Subject: phy: stm32: fix a refcount leak in stm32_usbphyc_pll_enable()
X-Git-Tag: v6.6.17~8192^2~4^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cfc826c88a79e22ba5d8001556eb2c7efd8a01b6;p=platform%2Fkernel%2Flinux-rpi.git

phy: stm32: fix a refcount leak in stm32_usbphyc_pll_enable()

This error path needs to decrement "usbphyc->n_pll_cons.counter" before
returning.

Fixes: 5b1af71280ab ("phy: stm32: rework PLL Lock detection")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220112111724.GB3019@kili
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---

diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
index 2ce9bfd..007a23c 100644
--- a/drivers/phy/st/phy-stm32-usbphyc.c
+++ b/drivers/phy/st/phy-stm32-usbphyc.c
@@ -304,7 +304,7 @@ static int stm32_usbphyc_pll_enable(struct stm32_usbphyc *usbphyc)
 
 		ret = __stm32_usbphyc_pll_disable(usbphyc);
 		if (ret)
-			return ret;
+			goto dec_n_pll_cons;
 	}
 
 	ret = stm32_usbphyc_regulators_enable(usbphyc);