From: Colin Ian King Date: Mon, 15 Aug 2016 12:55:17 +0000 (+0100) Subject: net: hns: mdio->irq is an array, so no need to check if it is null X-Git-Tag: v5.15~12647^2~97 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cfaace269d0ce5a4ae26bfe442f1c4df1a9558de;p=platform%2Fkernel%2Flinux-starfive.git net: hns: mdio->irq is an array, so no need to check if it is null The null check on mdio->irq is redundant since mdio->irq is an array of PHY_MAX_ADDR ints and hence can never be null. Remove the redundant check. Signed-off-by: Colin Ian King Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c index 5c8afe1..a834774 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c @@ -684,8 +684,7 @@ hns_mac_register_phydev(struct mii_bus *mdio, struct hns_mac_cb *mac_cb, if (!phy || IS_ERR(phy)) return -EIO; - if (mdio->irq) - phy->irq = mdio->irq[addr]; + phy->irq = mdio->irq[addr]; /* All data is now stored in the phy struct; * register it