From: Andy Shevchenko Date: Wed, 20 Mar 2013 12:14:30 +0000 (+0000) Subject: ACPI / LPSS: make code less confusing for reader X-Git-Tag: v3.10-rc1~22^2~12^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cf8df962aa830d05be1a8d5a9c7d2a67b2837b45;p=profile%2Fivi%2Fkernel-x86-ivi.git ACPI / LPSS: make code less confusing for reader The excerpt like this: if (err) { err = 0; goto error_out; } makes a reader confused even if it's commented. Let's do necessary actions and return no error explicitly. Signed-off-by: Andy Shevchenko Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c index c87db0e..b1c9542 100644 --- a/drivers/acpi/acpi_lpss.c +++ b/drivers/acpi/acpi_lpss.c @@ -150,8 +150,8 @@ static int acpi_lpss_create_device(struct acpi_device *adev, * Skip the device, but don't terminate the namespace * scan. */ - ret = 0; - goto err_out; + kfree(pdata); + return 0; } }