From: Uwe Kleine-König Date: Fri, 17 Feb 2023 09:53:17 +0000 (+0100) Subject: watchdog: at91rm9200: Only warn once about problems in .remove() X-Git-Tag: v6.6.7~3358^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cf3be7e82b129ed34f811f116f2b113f6299d449;p=platform%2Fkernel%2Flinux-starfive.git watchdog: at91rm9200: Only warn once about problems in .remove() The single difference between returning 0 and returning an error code in a platform remove callback is that in the latter case the platform core emits a warning about the error being ignored. at91wdt_remove() already emits a warning in the error case, so suppress the more generic (and less helpful) one by returning 0. Signed-off-by: Uwe Kleine-König Reviewed-by: Claudiu Beznea Reviewed-by: Guenter Roeck Link: https://lore.kernel.org/r/20230217095317.1213387-1-u.kleine-koenig@pengutronix.de Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck --- diff --git a/drivers/watchdog/at91rm9200_wdt.c b/drivers/watchdog/at91rm9200_wdt.c index 5126454..d57409c 100644 --- a/drivers/watchdog/at91rm9200_wdt.c +++ b/drivers/watchdog/at91rm9200_wdt.c @@ -270,7 +270,7 @@ static int at91wdt_remove(struct platform_device *pdev) misc_deregister(&at91wdt_miscdev); at91wdt_miscdev.parent = NULL; - return res; + return 0; } static void at91wdt_shutdown(struct platform_device *pdev)