From: Hugh Brown <hbrown@amplify.com>
Date: Thu, 10 Oct 2013 22:55:55 +0000 (-0400)
Subject: Lookup in dict
X-Git-Tag: v0.2.23~92^2~27
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cee0c7c61f7072126b4e923eb5185d731b7f4843;p=tools%2Fpython-jenkinsapi.git

Lookup in dict
---

diff --git a/jenkinsapi/nodes.py b/jenkinsapi/nodes.py
index 81e8379..d3ec02b 100644
--- a/jenkinsapi/nodes.py
+++ b/jenkinsapi/nodes.py
@@ -52,10 +52,11 @@ class Nodes(JenkinsBase):
                 ipdb.set_trace()
 
     def __getitem__(self, nodename):
-        for k, v in self.iteritems():
-            if k == nodename:
-                return v
-        raise UnknownNode(nodename)
+        self_as_dict = dict(self.iteritems())
+        if nodename in self_as_dict:
+            return self_as_dict[nodename]
+        else:
+            raise UnknownNode(nodename)
 
     def __len__(self):
         return len(self.iteritems())
diff --git a/jenkinsapi/result_set.py b/jenkinsapi/result_set.py
index 52b5b35..a765742 100644
--- a/jenkinsapi/result_set.py
+++ b/jenkinsapi/result_set.py
@@ -51,5 +51,5 @@ class ResultSet(JenkinsBase):
         return len(self.items())
 
     def __getitem__(self, key):
-        d = dict(self.iteritems())
-        return d[key]
+        self_as_dict = dict(self.iteritems())
+        return self_as_dict[key]