From: Nícolas F. R. A. Prado Date: Tue, 12 Jul 2022 21:45:54 +0000 (-0400) Subject: platform/chrome: cros_ec_typec: Use dev_err_probe on port register fail X-Git-Tag: v6.1-rc5~711^2~21 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ce838f7dc7957afb2846c3bc537db56e4c513390;p=platform%2Fkernel%2Flinux-starfive.git platform/chrome: cros_ec_typec: Use dev_err_probe on port register fail The typec_register_port() can fail with EPROBE_DEFER if the endpoint node hasn't probed yet. In order to avoid spamming the log with errors in that case, log using dev_err_probe(). Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: Guenter Roeck Reviewed-by: AngeloGioacchino Del Regno Link: https://lore.kernel.org/r/20220712214554.545035-1-nfraprado@collabora.com Signed-off-by: Prashant Malani --- diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index d6088ba..8c0ca3c 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -352,8 +352,8 @@ static int cros_typec_init_ports(struct cros_typec_data *typec) cros_port->port = typec_register_port(dev, cap); if (IS_ERR(cros_port->port)) { - dev_err(dev, "Failed to register port %d\n", port_num); ret = PTR_ERR(cros_port->port); + dev_err_probe(dev, ret, "Failed to register port %d\n", port_num); goto unregister_ports; }