From: Peter Hutterer <peter.hutterer@who-t.net>
Date: Fri, 23 Aug 2013 00:25:08 +0000 (+1000)
Subject: Rewrite libevdev_is_event_code to avoid signed/unsigned comparison
X-Git-Tag: libevdev-0.4~51
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ce7e2f15162f4a47766f97275dcce8fc1bff72e9;p=platform%2Fupstream%2Flibevdev.git

Rewrite libevdev_is_event_code to avoid signed/unsigned comparison

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
---

diff --git a/libevdev/libevdev.c b/libevdev/libevdev.c
index fbfd8f0..61795f6 100644
--- a/libevdev/libevdev.c
+++ b/libevdev/libevdev.c
@@ -1172,10 +1172,13 @@ libevdev_is_event_type(const struct input_event *ev, unsigned int type)
 int
 libevdev_is_event_code(const struct input_event *ev, unsigned int type, unsigned int code)
 {
-	return type < EV_MAX &&
-		ev->type == type &&
-		(type == EV_SYN || code <= libevdev_get_event_type_max(type)) &&
-		ev->code == code;
+	int max;
+
+	if (!libevdev_is_event_type(ev, type))
+		return 0;
+
+	max = libevdev_get_event_type_max(type);
+	return (max > -1 && code <= (unsigned int)max && ev->code == code);
 }
 
 const char*