From: Hui Wang Date: Wed, 30 Nov 2022 09:08:00 +0000 (+0800) Subject: dmaengine: imx-sdma: Fix a possible memory leak in sdma_transfer_init X-Git-Tag: v6.1.15~544 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ce4745a6b8016fae74c95dcd457d4ceef7d98af1;hp=6b1cebcd9e89a306bd2842f960da839209c696cd;p=platform%2Fkernel%2Flinux-starfive.git dmaengine: imx-sdma: Fix a possible memory leak in sdma_transfer_init [ Upstream commit 1417f59ac0b02130ee56c0c50794b9b257be3d17 ] If the function sdma_load_context() fails, the sdma_desc will be freed, but the allocated desc->bd is forgot to be freed. We already met the sdma_load_context() failure case and the log as below: [ 450.699064] imx-sdma 30bd0000.dma-controller: Timeout waiting for CH0 ready ... In this case, the desc->bd will not be freed without this change. Signed-off-by: Hui Wang Reviewed-by: Sascha Hauer Link: https://lore.kernel.org/r/20221130090800.102035-1-hui.wang@canonical.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index fbea5f6..b926abe 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -1521,10 +1521,12 @@ static struct sdma_desc *sdma_transfer_init(struct sdma_channel *sdmac, sdma_config_ownership(sdmac, false, true, false); if (sdma_load_context(sdmac)) - goto err_desc_out; + goto err_bd_out; return desc; +err_bd_out: + sdma_free_bd(desc); err_desc_out: kfree(desc); err_out: