From: Clément Léger <cleger@rivosinc.com>
Date: Tue, 9 Apr 2024 10:02:06 +0000 (+0200)
Subject: lib: sbi: sse: call enable callback before sending IPI
X-Git-Tag: v1.5~45
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ce3c82cb2e2d6e41912b97c4f99e8567fadf445e;p=platform%2Fkernel%2Fopensbi.git

lib: sbi: sse: call enable callback before sending IPI

Move the enable callback call before sending the IPI. Even though the
event is locked and no race condition can happen, this is more logical.

Signed-off-by: Clément Léger <cleger@rivosinc.com>
Reported-by: Samuel Holland <samuel.holland@sifive.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
---

diff --git a/lib/sbi/sbi_sse.c b/lib/sbi/sbi_sse.c
index 2c7f78d..fb327f0 100644
--- a/lib/sbi/sbi_sse.c
+++ b/lib/sbi/sbi_sse.c
@@ -686,12 +686,12 @@ static int sse_event_enable(struct sbi_sse_event *e)
 	sse_event_set_state(e, SBI_SSE_STATE_ENABLED);
 	sse_event_add_to_list(e);
 
-	if (sse_event_pending(e))
+	sse_event_invoke_cb(e, enable_cb);
+
+	if (sse_event_is_global(e) && sse_event_pending(e))
 		sbi_ipi_send_many(1, e->attrs.hartid, sse_ipi_inject_event,
 				  NULL);
 
-	sse_event_invoke_cb(e, enable_cb);
-
 	return SBI_OK;
 }