From: Wang Shilong Date: Wed, 3 Oct 2018 16:19:21 +0000 (-0400) Subject: ext4: propagate error from dquot_initialize() in EXT4_IOC_FSSETXATTR X-Git-Tag: v4.19.2~134 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ce1daaa84d87a633a0668307dfa279037d6e8fcd;p=platform%2Fkernel%2Flinux-rpi.git ext4: propagate error from dquot_initialize() in EXT4_IOC_FSSETXATTR commit 182a79e0c17147d2c2d3990a9a7b6b58a1561c7a upstream. We return most failure of dquota_initialize() except inode evict, this could make a bit sense, for example we allow file removal even quota files are broken? But it dosen't make sense to allow setting project if quota files etc are broken. Signed-off-by: Wang Shilong Signed-off-by: Theodore Ts'o Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index 0b3e248..0edee31 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -380,7 +380,9 @@ static int ext4_ioctl_setproject(struct file *filp, __u32 projid) brelse(iloc.bh); } - dquot_initialize(inode); + err = dquot_initialize(inode); + if (err) + return err; handle = ext4_journal_start(inode, EXT4_HT_QUOTA, EXT4_QUOTA_INIT_BLOCKS(sb) +