From: Rui Xiang Date: Thu, 23 Jan 2014 23:55:41 +0000 (-0800) Subject: proc: set attributes of pde using accessor functions X-Git-Tag: submit/tizen/20141203.153721~733^2~34 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cdf7e8dded6212cb29f758017a613e4eefc4ce9e;p=platform%2Fkernel%2Flinux-arm64.git proc: set attributes of pde using accessor functions Use existing accessors proc_set_user() and proc_set_size() to set attributes. Just a cleanup. Signed-off-by: Rui Xiang Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/proc/generic.c b/fs/proc/generic.c index cca93b6fb9a..b7f268eb5f4 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c @@ -49,8 +49,7 @@ static int proc_notify_change(struct dentry *dentry, struct iattr *iattr) setattr_copy(inode, iattr); mark_inode_dirty(inode); - de->uid = inode->i_uid; - de->gid = inode->i_gid; + proc_set_user(de, inode->i_uid, inode->i_gid); de->mode = inode->i_mode; return 0; } diff --git a/fs/proc/proc_devtree.c b/fs/proc/proc_devtree.c index 70779b2fc20..c824187251f 100644 --- a/fs/proc/proc_devtree.c +++ b/fs/proc/proc_devtree.c @@ -74,9 +74,9 @@ __proc_device_tree_add_prop(struct proc_dir_entry *de, struct property *pp, return NULL; if (!strncmp(name, "security-", 9)) - ent->size = 0; /* don't leak number of password chars */ + proc_set_size(ent, 0); /* don't leak number of password chars */ else - ent->size = pp->length; + proc_set_size(ent, pp->length); return ent; }