From: Gavin Shan Date: Thu, 4 Apr 2013 16:54:31 +0000 (+0000) Subject: PCI: Remove MSI/MSI-X cap check in pci_msi_check_device() X-Git-Tag: v3.10-rc1~198^2^2~15 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cdf1fd4d906bc8c06510fd3e1d6a073441792792;p=profile%2Fivi%2Fkernel-x86-ivi.git PCI: Remove MSI/MSI-X cap check in pci_msi_check_device() The function pci_msi_check_device() is called while enabling MSI or MSI-X interrupts to make sure the PCI device can support MSI or MSI-X capability. This patch removes the check on MSI or MSI-X capability in the function and lets the caller do the check. Signed-off-by: Gavin Shan Signed-off-by: Bjorn Helgaas --- diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 99befbd..60a4b10 100644 --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -789,9 +789,6 @@ static int pci_msi_check_device(struct pci_dev *dev, int nvec, int type) if (ret) return ret; - if (!pci_find_capability(dev, type)) - return -EINVAL; - return 0; } @@ -942,7 +939,7 @@ int pci_enable_msix(struct pci_dev *dev, struct msix_entry *entries, int nvec) int status, nr_entries; int i, j; - if (!entries) + if (!entries || !dev->msix_cap) return -EINVAL; status = pci_msi_check_device(dev, nvec, PCI_CAP_ID_MSIX);