From: Jakub Lichman Date: Mon, 22 Jun 2020 11:23:39 +0000 (+0200) Subject: [mlir] Fix linalg.generic matmul example in the doc X-Git-Tag: llvmorg-12-init~2355 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cde2dc2fa6ca9f34a550acebac7eb81d46e62a60;p=platform%2Fupstream%2Fllvm.git [mlir] Fix linalg.generic matmul example in the doc Example of Matmul implementation in linalg.generic operation contained few mistakes that can puzzle new startes when trying to run the example. Differential Revision: https://reviews.llvm.org/D82289 --- diff --git a/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td b/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td index 85fdd1e..067d7c2 100644 --- a/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td +++ b/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td @@ -562,10 +562,10 @@ def GenericOp : GenericOpBase<"generic"> { And can be reused in multiple places as: ```mlir linalg.generic #matmul_trait %A, %B, %C [other-attributes] { - (%a: f32, %b: f32, %c: f32) : + ^bb0(%a: f32, %b: f32, %c: f32) : %d = mulf %a, %b: f32 %e = addf %c, %d: f32 - linalg_yield %e : f32 + linalg.yield %e : f32 } : memref, memref, memref