From: Stanislaw Gruszka Date: Wed, 23 Mar 2011 02:44:30 +0000 (+0000) Subject: myri10ge: fix rmmod crash X-Git-Tag: upstream/snapshot3+hdmi~10756^2~42 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cda6587c21a887254c8ed4b58da8fcc4040ab557;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git myri10ge: fix rmmod crash Rmmod myri10ge crash at free_netdev() -> netif_napi_del(), because napi structures are already deallocated. To fix call netif_napi_del() before kfree() at myri10ge_free_slices(). Cc: stable@kernel.org Signed-off-by: Stanislaw Gruszka Signed-off-by: David S. Miller --- diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c index a7f2eed..1f4e868 100644 --- a/drivers/net/myri10ge/myri10ge.c +++ b/drivers/net/myri10ge/myri10ge.c @@ -3645,6 +3645,7 @@ static void myri10ge_free_slices(struct myri10ge_priv *mgp) dma_free_coherent(&pdev->dev, bytes, ss->fw_stats, ss->fw_stats_bus); ss->fw_stats = NULL; + netif_napi_del(&ss->napi); } } kfree(mgp->ss);