From: sayli karnik <karniksayli1995@gmail.com>
Date: Mon, 19 Sep 2016 14:32:40 +0000 (+0530)
Subject: staging: i4l: act2000: Move assignment out of if statement
X-Git-Tag: v4.9.8~1233^2~312
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cd9ae9e4db8a62cfbdaec2d73f8c34eea66c48d5;p=platform%2Fkernel%2Flinux-rpi3.git

staging: i4l: act2000: Move assignment out of if statement

This patch places assignments which are inside the if condition, above it.
Done using coccinelle:

@@
statement s;
expression e;
identifier id;
@@
- if ((id = e))
+ id = e;
+ if (id)
        s

Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/i4l/act2000/module.c b/drivers/staging/i4l/act2000/module.c
index 39a8940..99c9c0a 100644
--- a/drivers/staging/i4l/act2000/module.c
+++ b/drivers/staging/i4l/act2000/module.c
@@ -289,7 +289,8 @@ act2000_command(act2000_card *card, isdn_ctrl *c)
 			if (copy_from_user(tmp, arg,
 					   sizeof(tmp)))
 				return -EFAULT;
-			if ((ret = act2000_set_msn(card, tmp)))
+			ret = act2000_set_msn(card, tmp);
+			if (ret)
 				return ret;
 			if (card->flags & ACT2000_FLAGS_RUNNING)
 				return (actcapi_manufacturer_req_msn(card));