From: Ben Skeggs <skeggsb@gmail.com>
Date: Fri, 7 Mar 2008 03:38:05 +0000 (+1100)
Subject: nouveau: don't touch NV_USER regs on channel destroy.
X-Git-Tag: submit/1.0/20121108.012404~964
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cd924de02927a091c517b0ac6b9cd8f065ce448c;p=profile%2Fivi%2Flibdrm.git

nouveau: don't touch NV_USER regs on channel destroy.

Not only was this entirely pointless, it actually causes my NV30GL to
die randomly when channels are destroyed.
---

diff --git a/shared-core/nouveau_fifo.c b/shared-core/nouveau_fifo.c
index 056cb6d..8e93207 100644
--- a/shared-core/nouveau_fifo.c
+++ b/shared-core/nouveau_fifo.c
@@ -433,13 +433,6 @@ void nouveau_fifo_free(struct nouveau_channel *chan)
 	NV_WRITE(NV03_PFIFO_CACHE1_PUSH0, 0x00000000);
 	NV_WRITE(NV04_PFIFO_CACHE1_PULL0, 0x00000000);
 
-	/* stop the fifo, otherwise it could be running and
-	 * it will crash when removing gpu objects
-	 *XXX: from real-world evidence, absolutely useless..
-	 */
-	NV_WRITE(chan->get, chan->pushbuf_base);
-	NV_WRITE(chan->put, chan->pushbuf_base);
-
 	// FIXME XXX needs more code
 
 	engine->fifo.destroy_context(chan);