From: Sebastian Dröge <sebastian@centricular.com>
Date: Tue, 2 May 2017 11:35:50 +0000 (+0300)
Subject: message: Don't pass a NULL debug string to g_utf8_validate()
X-Git-Tag: 1.12.0~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cd3a49b69bc013d1722b5a57e37ee03f9afc1a6b;p=platform%2Fupstream%2Fgstreamer.git

message: Don't pass a NULL debug string to g_utf8_validate()

g_utf8_validate() crashes on NULL, but NULL is valid for the debug
string nonetheless.
---

diff --git a/gst/gstmessage.c b/gst/gstmessage.c
index e426d3c455..5f36662e58 100644
--- a/gst/gstmessage.c
+++ b/gst/gstmessage.c
@@ -416,7 +416,7 @@ gst_message_new_error_with_details (GstObject * src, GError * error,
   GstMessage *message;
   GstStructure *structure;
 
-  if (!g_utf8_validate (debug, -1, NULL)) {
+  if (debug && !g_utf8_validate (debug, -1, NULL)) {
     debug = NULL;
     g_warning ("Trying to set debug field of error message, but "
         "string is not valid UTF-8. Please file a bug.");
@@ -508,7 +508,7 @@ gst_message_new_warning_with_details (GstObject * src, GError * error,
   GstMessage *message;
   GstStructure *structure;
 
-  if (!g_utf8_validate (debug, -1, NULL)) {
+  if (debug && !g_utf8_validate (debug, -1, NULL)) {
     debug = NULL;
     g_warning ("Trying to set debug field of warning message, but "
         "string is not valid UTF-8. Please file a bug.");
@@ -598,7 +598,7 @@ gst_message_new_info_with_details (GstObject * src, GError * error,
   GstMessage *message;
   GstStructure *structure;
 
-  if (!g_utf8_validate (debug, -1, NULL)) {
+  if (debug && !g_utf8_validate (debug, -1, NULL)) {
     debug = NULL;
     g_warning ("Trying to set debug field of info message, but "
         "string is not valid UTF-8. Please file a bug.");