From: Xin Long Date: Thu, 24 Feb 2022 03:41:08 +0000 (-0500) Subject: ping: remove pr_err from ping_lookup X-Git-Tag: v6.6.17~8134^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cd33bdcbead882c2e58fdb4a54a7bd75b610a452;p=platform%2Fkernel%2Flinux-rpi.git ping: remove pr_err from ping_lookup As Jakub noticed, prints should be avoided on the datapath. Also, as packets would never come to the else branch in ping_lookup(), remove pr_err() from ping_lookup(). Fixes: 35a79e64de29 ("ping: fix the dif and sdif check in ping_lookup") Reported-by: Jakub Kicinski Signed-off-by: Xin Long Link: https://lore.kernel.org/r/1ef3f2fcd31bd681a193b1fcf235eee1603819bd.1645674068.git.lucien.xin@gmail.com Signed-off-by: Jakub Kicinski --- diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c index 3a5994b..3ee9475 100644 --- a/net/ipv4/ping.c +++ b/net/ipv4/ping.c @@ -187,7 +187,6 @@ static struct sock *ping_lookup(struct net *net, struct sk_buff *skb, u16 ident) (int)ident, &ipv6_hdr(skb)->daddr, dif); #endif } else { - pr_err("ping: protocol(%x) is not supported\n", ntohs(skb->protocol)); return NULL; }