From: Yang Yingliang Date: Wed, 9 Nov 2022 14:01:24 +0000 (+0800) Subject: tee: optee: fix possible memory leak in optee_register_device() X-Git-Tag: v6.1~82^2~7^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cce616e012c215d65c15e5d1afa73182dea49389;p=platform%2Fkernel%2Flinux-starfive.git tee: optee: fix possible memory leak in optee_register_device() If device_register() returns error in optee_register_device(), the name allocated by dev_set_name() need be freed. As comment of device_register() says, it should use put_device() to give up the reference in the error path. So fix this by calling put_device(), then the name can be freed in kobject_cleanup(), and optee_device is freed in optee_release_device(). Fixes: c3fa24af9244 ("tee: optee: add TEE bus device enumeration support") Signed-off-by: Yang Yingliang Reviewed-by: Sumit Garg Signed-off-by: Jens Wiklander --- diff --git a/drivers/tee/optee/device.c b/drivers/tee/optee/device.c index f3947be..64f0e04 100644 --- a/drivers/tee/optee/device.c +++ b/drivers/tee/optee/device.c @@ -80,7 +80,7 @@ static int optee_register_device(const uuid_t *device_uuid) rc = device_register(&optee_device->dev); if (rc) { pr_err("device registration failed, err: %d\n", rc); - kfree(optee_device); + put_device(&optee_device->dev); } return rc;