From: Xiang W <wxjstz@126.com>
Date: Sun, 9 Jul 2023 16:02:29 +0000 (+0800)
Subject: lib: sbi: Fix printc
X-Git-Tag: v1.4~143
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cc89fa7b5481b3279f1628f71debf795d5618044;p=platform%2Fkernel%2Fopensbi.git

lib: sbi: Fix printc

Because *out needs to reserve a byte to hold '\0', no more characters
should be added to the buffer when *out has one byte left, and the
buffer size *out_len should not be modified. this patch prevents
the correction of *out_len when *out_len is 1.

Signed-off-by: Xiang W <wxjstz@126.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
---

diff --git a/lib/sbi/sbi_console.c b/lib/sbi/sbi_console.c
index adbe2e6..6915148 100644
--- a/lib/sbi/sbi_console.c
+++ b/lib/sbi/sbi_console.c
@@ -142,10 +142,9 @@ static void printc(char **out, u32 *out_len, char ch)
 	if (!out_len || *out_len > 1) {
 		*(*out)++ = ch;
 		**out = '\0';
+		if (out_len)
+			--(*out_len);
 	}
-
-	if (out_len && *out_len > 0)
-		--(*out_len);
 }
 
 static int prints(char **out, u32 *out_len, const char *string, int width,