From: Geert Uytterhoeven Date: Wed, 14 Dec 2016 11:20:55 +0000 (+0100) Subject: spi: fsl-lpspi: Pre-initialize ret in fsl_lpspi_transfer_one_msg() X-Git-Tag: v4.11-rc1~153^2~3^5~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cc4a7ffe02c95f537541c91e9842e3710decae6e;p=platform%2Fkernel%2Flinux-exynos.git spi: fsl-lpspi: Pre-initialize ret in fsl_lpspi_transfer_one_msg() With gcc 4.1.2: drivers/spi/spi-fsl-lpspi.c: In function ‘fsl_lpspi_transfer_one_msg’: drivers/spi/spi-fsl-lpspi.c:369: warning: ‘ret’ may be used uninitialized in this function If the message contains no transfers, the function will set the message's status to an uninitialized value, and will return that uninitialized value. While __spi_validate() should have been called in all paths leading to this, and thus have rejected such messages, we better pre-initialize ret to be safe for future modifications (spi_transfer_one_message() also does this). Signed-off-by: Geert Uytterhoeven Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 52551f6..2b93bc6 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -366,7 +366,7 @@ static int fsl_lpspi_transfer_one_msg(struct spi_master *master, struct spi_transfer *xfer; bool is_first_xfer = true; u32 temp; - int ret; + int ret = 0; msg->status = 0; msg->actual_length = 0;