From: Dan Carpenter Date: Sun, 21 Oct 2018 11:05:49 +0000 (+0300) Subject: net/mlx5: Allocate enough space for the FDB sub-namespaces X-Git-Tag: v5.15~7778^2~17 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cc3a4cd3f016a081a29b938f1ad17669bfacc9b2;p=platform%2Fkernel%2Flinux-starfive.git net/mlx5: Allocate enough space for the FDB sub-namespaces FDB_MAX_CHAIN is three. We wanted to allocate enough memory to hold four structs but there are missing parentheses so we only allocate enough memory for three structs and the first byte of the fourth one. Fixes: 328edb499f99 ("net/mlx5: Split FDB fast path prio to multiple namespaces") Signed-off-by: Dan Carpenter Reviewed-by: Or Gerlitz Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c index 67ba4c9..9d73eb9 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c @@ -2470,7 +2470,7 @@ static int init_fdb_root_ns(struct mlx5_flow_steering *steering) return -ENOMEM; steering->fdb_sub_ns = kzalloc(sizeof(steering->fdb_sub_ns) * - FDB_MAX_CHAIN + 1, GFP_KERNEL); + (FDB_MAX_CHAIN + 1), GFP_KERNEL); if (!steering->fdb_sub_ns) return -ENOMEM;