From: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Date: Fri, 27 Oct 2023 10:28:02 +0000 (+0900)
Subject: [Edge] Add cond for nns_edge_handle
X-Git-Tag: accepted/tizen/unified/20231110.172145^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cbbdd7cb73e646491adcd05793bfb0d3c789173d;p=platform%2Fupstream%2Fnnstreamer-edge.git

[Edge] Add cond for nns_edge_handle

- Add a pthread_cond for nns_edge_handle. And let the start method wait
  for the cond to be signaled by send_thread.
- This prevents some race conditions when APIs are used while
  send_thread is not yet started.

Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
---

diff --git a/src/libnnstreamer-edge/nnstreamer-edge-internal.c b/src/libnnstreamer-edge/nnstreamer-edge-internal.c
index 7f64fd0..f0293fc 100644
--- a/src/libnnstreamer-edge/nnstreamer-edge-internal.c
+++ b/src/libnnstreamer-edge/nnstreamer-edge-internal.c
@@ -38,6 +38,7 @@ typedef struct
 {
   uint32_t magic;
   pthread_mutex_t lock;
+  pthread_cond_t cond;
   char *id;
   char *topic;
   nns_edge_connect_type_e connect_type;
@@ -833,6 +834,7 @@ _nns_edge_send_thread (void *thread_data)
   int ret;
 
   eh->sending = true;
+  nns_edge_cond_signal (eh);
   while (eh->sending &&
       NNS_EDGE_ERROR_NONE == nns_edge_queue_wait_pop (eh->send_queue, 0U,
           &data_h, &data_size)) {
@@ -905,6 +907,9 @@ _nns_edge_create_send_thread (nns_edge_handle_s * eh)
   int status;
 
   status = pthread_create (&eh->send_thread, NULL, _nns_edge_send_thread, eh);
+  while (!eh->sending) {
+    nns_edge_cond_wait (eh);
+  }
 
   if (status != 0) {
     nns_edge_loge ("Failed to create sender thread.");
@@ -1244,6 +1249,7 @@ nns_edge_create_handle (const char *id, nns_edge_connect_type_e connect_type,
   }
 
   nns_edge_lock_init (eh);
+  nns_edge_cond_init (eh);
   nns_edge_handle_set_magic (eh, NNS_EDGE_MAGIC);
   eh->id = STR_IS_VALID (id) ? nns_edge_strdup (id) :
       nns_edge_strdup_printf ("%lld", (long long) nns_edge_generate_id ());
@@ -1473,6 +1479,7 @@ nns_edge_release_handle (nns_edge_h edge_h)
   SAFE_FREE (eh->caps_str);
 
   nns_edge_unlock (eh);
+  nns_edge_cond_destroy (eh);
   nns_edge_lock_destroy (eh);
   SAFE_FREE (eh);