From: H Hartley Sweeten Date: Tue, 14 May 2013 20:38:00 +0000 (-0700) Subject: staging: comedi: usbduxfast: tidy up usbduxfastsub_unlink_InURBs() X-Git-Tag: v5.15~19849^2~646 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cb8c0034781388e5213d766b7509b2330f57e652;p=platform%2Fkernel%2Flinux-starfive.git staging: comedi: usbduxfast: tidy up usbduxfastsub_unlink_InURBs() Rename this function so it has namespace associated with the driver. Remove the local variables 'j' and 'ret'. They are not used and the function always returns '0'. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/usbduxfast.c b/drivers/staging/comedi/drivers/usbduxfast.c index dd7c53f..e1c3787 100644 --- a/drivers/staging/comedi/drivers/usbduxfast.c +++ b/drivers/staging/comedi/drivers/usbduxfast.c @@ -189,19 +189,16 @@ static int usbduxfast_send_cmd(struct comedi_device *dev, int cmd_type) * Stops the data acquision. * It should be safe to call this function from any context. */ -static int usbduxfastsub_unlink_InURBs(struct comedi_device *dev) +static int usbduxfast_unlink_urbs(struct comedi_device *dev) { struct usbduxfast_private *devpriv = dev->private; - int j = 0; - int err = 0; if (devpriv && devpriv->urb) { devpriv->ai_cmd_running = 0; /* waits until a running transfer is over */ usb_kill_urb(devpriv->urb); - j = 0; } - return err; + return 0; } /* @@ -224,7 +221,7 @@ static int usbduxfast_ai_stop(struct comedi_device *dev, if (do_unlink) /* stop aquistion */ - ret = usbduxfastsub_unlink_InURBs(dev); + ret = usbduxfast_unlink_urbs(dev); return ret; }