From: Michel Dänzer Date: Tue, 18 Sep 2018 15:23:04 +0000 (+0200) Subject: gallium/util: Clarify comment in util_init_thread_pinning X-Git-Tag: upstream/19.0.0~2364 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cb863de626486a10273281e89534471549a242a7;p=platform%2Fupstream%2Fmesa.git gallium/util: Clarify comment in util_init_thread_pinning As discussed in the review of the patch which added the comment: Nothing happens when a thread is created, because pthread_atfork doesn't affect creating threads. However, spawning a child process will likely crash. Reviewed-by: Marek Olšák --- diff --git a/src/gallium/auxiliary/util/u_helpers.c b/src/gallium/auxiliary/util/u_helpers.c index b6cebf9..4c70c00 100644 --- a/src/gallium/auxiliary/util/u_helpers.c +++ b/src/gallium/auxiliary/util/u_helpers.c @@ -148,7 +148,10 @@ util_init_thread_pinning(void) /* Reset thread affinity for all child processes to prevent them from * inheriting the current thread's affinity. * - * What happens if a driver is unloaded and the app creates a thread? + * XXX: If the driver is unloaded after this, and the app later calls + * fork(), the child process will likely crash before fork() returns, + * because the address where util_set_full_cpu_affinity was located + * will either be unmapped or point to random other contents. */ pthread_atfork(NULL, NULL, util_set_full_cpu_affinity); }