From: Mike Frysinger Date: Tue, 13 Apr 2010 20:28:20 +0000 (+0000) Subject: sim: constify sim_write source buffer X-Git-Tag: sid-snapshot-20100501~230 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cb1cc9c67ab42392913b61d630a3f72369e1c9ac;p=external%2Fbinutils.git sim: constify sim_write source buffer Most the sim write functions declare their source buffer const because they only ever read from it. The global sim_write() function does not follow this convention though which causes some warnings when trying to pass it const strings or buffers. Signed-off-by: Mike Frysinger --- diff --git a/include/gdb/ChangeLog b/include/gdb/ChangeLog index 3b84cad..119264e 100644 --- a/include/gdb/ChangeLog +++ b/include/gdb/ChangeLog @@ -1,3 +1,7 @@ +2010-04-13 Mike Frysinger + + * remote-sim.h (sim_write): Add const to buf arg. + 2009-11-24 DJ Delorie * sim-rx.h: New. diff --git a/include/gdb/remote-sim.h b/include/gdb/remote-sim.h index cfb1c11..37f029a 100644 --- a/include/gdb/remote-sim.h +++ b/include/gdb/remote-sim.h @@ -175,7 +175,7 @@ int sim_read PARAMS ((SIM_DESC sd, SIM_ADDR mem, unsigned char *buf, int length) memory. Store bytes starting at virtual address MEM. Result is number of bytes write, or zero if error. */ -int sim_write PARAMS ((SIM_DESC sd, SIM_ADDR mem, unsigned char *buf, int length)); +int sim_write PARAMS ((SIM_DESC sd, SIM_ADDR mem, const unsigned char *buf, int length)); /* Fetch register REGNO storing its raw (target endian) value in the diff --git a/sim/common/ChangeLog b/sim/common/ChangeLog index 71f4613..2a386d7 100644 --- a/sim/common/ChangeLog +++ b/sim/common/ChangeLog @@ -1,3 +1,8 @@ +2010-04-13 Mike Frysinger + + * sim-hrw.c (sim_write): Add const to buf arg. + * sim-utils.h (sim_write_fn): Likewise. + 2010-04-12 Mike Frysinger * sim-profile.h (PROFILE_BRANCH_TAKEN, PROFILE_BRANCH_UNTAKEN): New diff --git a/sim/common/sim-hrw.c b/sim/common/sim-hrw.c index e76a196..cedae87 100644 --- a/sim/common/sim-hrw.c +++ b/sim/common/sim-hrw.c @@ -32,7 +32,7 @@ sim_read (SIM_DESC sd, SIM_ADDR mem, unsigned char *buf, int length) } int -sim_write (SIM_DESC sd, SIM_ADDR mem, unsigned char *buf, int length) +sim_write (SIM_DESC sd, SIM_ADDR mem, const unsigned char *buf, int length) { SIM_ASSERT (STATE_MAGIC (sd) == SIM_MAGIC_NUMBER); return sim_core_write_buffer (sd, NULL, write_map, diff --git a/sim/common/sim-utils.h b/sim/common/sim-utils.h index 75d2fb4..e3ff63a 100644 --- a/sim/common/sim-utils.h +++ b/sim/common/sim-utils.h @@ -63,7 +63,7 @@ SIM_RC sim_analyze_program (SIM_DESC sd, char *prog_name, This is still accommodated for backward compatibility reasons. */ typedef int sim_write_fn PARAMS ((SIM_DESC sd, SIM_ADDR mem, - unsigned char *buf, int length)); + const unsigned char *buf, int length)); struct bfd *sim_load_file (SIM_DESC sd, const char *myname, host_callback *callback, char *prog, struct bfd *prog_bfd, int verbose_p,