From: Johan Hovold Date: Thu, 16 Mar 2017 18:41:55 +0000 (-0700) Subject: Input: kbtab - validate number of endpoints before using them X-Git-Tag: v4.14-rc1~4^2~44 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cb1b494663e037253337623bf1ef2df727883cb7;p=platform%2Fkernel%2Flinux-rpi.git Input: kbtab - validate number of endpoints before using them Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack endpoints. Signed-off-by: Johan Hovold Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov --- diff --git a/drivers/input/tablet/kbtab.c b/drivers/input/tablet/kbtab.c index e850d7e..4d9d649 100644 --- a/drivers/input/tablet/kbtab.c +++ b/drivers/input/tablet/kbtab.c @@ -122,6 +122,9 @@ static int kbtab_probe(struct usb_interface *intf, const struct usb_device_id *i struct input_dev *input_dev; int error = -ENOMEM; + if (intf->cur_altsetting->desc.bNumEndpoints < 1) + return -ENODEV; + kbtab = kzalloc(sizeof(struct kbtab), GFP_KERNEL); input_dev = input_allocate_device(); if (!kbtab || !input_dev)