From: Tim-Philipp Müller Date: Wed, 1 Apr 2009 11:26:12 +0000 (+0100) Subject: rtspsrc: don't emit ugly warnings with older rtpjitterbuffer versions X-Git-Tag: RELEASE-0.10.15~341 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cb15d09c4af37c2d8af80c7e9e0133875a0d4170;p=platform%2Fupstream%2Fgst-plugins-good.git rtspsrc: don't emit ugly warnings with older rtpjitterbuffer versions The on-npt-stop signals was added only recently to rtpjitterbuffer in -bad, so check if the signal exists before g_signal_connect()ing to it, to avoid warnings. --- diff --git a/gst/rtsp/gstrtspsrc.c b/gst/rtsp/gstrtspsrc.c index 667211a..262d4b9 100644 --- a/gst/rtsp/gstrtspsrc.c +++ b/gst/rtsp/gstrtspsrc.c @@ -1948,8 +1948,13 @@ gst_rtspsrc_stream_configure_manager (GstRTSPSrc * src, GstRTSPStream * stream, src); g_signal_connect (src->session, "on-timeout", (GCallback) on_timeout, src); - g_signal_connect (src->session, "on-npt-stop", (GCallback) on_npt_stop, - src); + /* FIXME: remove this once the rtpjitterbuffer is in -good */ + if (g_signal_lookup ("on-npt-stop", G_OBJECT_TYPE (src->session)) != 0) { + g_signal_connect (src->session, "on-npt-stop", (GCallback) on_npt_stop, + src); + } else { + GST_INFO_OBJECT (src, "skipping on-npt-stop handling, not implemented"); + } } /* we stream directly to the manager, get some pads. Each RTSP stream goes