From: Jules Irenge Date: Wed, 29 Apr 2020 22:57:22 +0000 (+0100) Subject: cxgb4: Add missing annotation for service_ofldq() X-Git-Tag: v5.15~3931^2~37 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cae9566acb1a4533ca85b63f7ac0cc7ebe4a0c30;p=platform%2Fkernel%2Flinux-starfive.git cxgb4: Add missing annotation for service_ofldq() Sparse reports a warning at service_ofldq() warning: context imbalance in service_ofldq() - unexpected unlock The root cause is the missing annotation at service_ofldq() Add the missing __must_hold(&q->sendq.lock) annotation Signed-off-by: Jules Irenge Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c index 2cfb1f6..6516c45 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/sge.c +++ b/drivers/net/ethernet/chelsio/cxgb4/sge.c @@ -2728,6 +2728,7 @@ static void ofldtxq_stop(struct sge_uld_txq *q, struct fw_wr_hdr *wr) * is ever running at a time ... */ static void service_ofldq(struct sge_uld_txq *q) + __must_hold(&q->sendq.lock) { u64 *pos, *before, *end; int credits;