From: David S. Miller Date: Wed, 10 Jul 2019 04:35:08 +0000 (-0700) Subject: mlx5: Return -EINVAL when WARN_ON_ONCE triggers in mlx5e_tls_resync(). X-Git-Tag: v5.4-rc1~616^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=cacf32e99788e91a3eaefafb0976deadf84f37d5;p=platform%2Fkernel%2Flinux-rpi.git mlx5: Return -EINVAL when WARN_ON_ONCE triggers in mlx5e_tls_resync(). Return value was changes to 'int' from void but this return statement was not updated, or it slipped in via a merge. Fixes: b5d9a834f4fd ("net/tls: don't clear TX resync flag on error") Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c index ca07c86..fba561ff 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c @@ -170,7 +170,7 @@ static int mlx5e_tls_resync(struct net_device *netdev, struct sock *sk, u64 rcd_sn = *(u64 *)rcd_sn_data; if (WARN_ON_ONCE(direction != TLS_OFFLOAD_CTX_DIR_RX)) - return; + return -EINVAL; rx_ctx = mlx5e_get_tls_rx_context(tls_ctx); netdev_info(netdev, "resyncing seq %d rcd %lld\n", seq,