From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 12 Jun 2018 12:03:02 +0000 (+0300)
Subject: rtc: mrst: fix error code in probe()
X-Git-Tag: v4.18-rc5~2^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ca95ef7c98674a8eb5d411fc0835783051c0662b;p=platform%2Fkernel%2Flinux-exynos.git

rtc: mrst: fix error code in probe()

We should be returning "retval".  The "mrst_rtc.rtc" variable is a valid
pointer.

Fixes: 32b41f93dcaf ("rtc: mrst: switch to devm functions")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---

diff --git a/drivers/rtc/rtc-mrst.c b/drivers/rtc/rtc-mrst.c
index 097a4d4e2aba..1925aaf09093 100644
--- a/drivers/rtc/rtc-mrst.c
+++ b/drivers/rtc/rtc-mrst.c
@@ -367,10 +367,8 @@ static int vrtc_mrst_do_probe(struct device *dev, struct resource *iomem,
 	}
 
 	retval = rtc_register_device(mrst_rtc.rtc);
-	if (retval) {
-		retval = PTR_ERR(mrst_rtc.rtc);
+	if (retval)
 		goto cleanup0;
-	}
 
 	dev_dbg(dev, "initialised\n");
 	return 0;