From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 8 Mar 2017 05:22:37 +0000 (+0300)
Subject: NFC: nfcmrvl: double free on error path
X-Git-Tag: v4.14-rc1~1025^2~129^2~24
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ca42fb9e52d155547e6cf18cf26bce3e1a6af4ea;p=platform%2Fkernel%2Flinux-rpi.git

NFC: nfcmrvl: double free on error path

The nci_spi_send() function calls kfree_skb(skb) on both error and
success so this extra kfree_skb() is a double free.

Fixes: caf6e49bf6d0 ("NFC: nfcmrvl: add spi driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
---

diff --git a/drivers/nfc/nfcmrvl/spi.c b/drivers/nfc/nfcmrvl/spi.c
index e2881b15..8e0ddb4 100644
--- a/drivers/nfc/nfcmrvl/spi.c
+++ b/drivers/nfc/nfcmrvl/spi.c
@@ -95,10 +95,9 @@ static int nfcmrvl_spi_nci_send(struct nfcmrvl_private *priv,
 	/* Send the SPI packet */
 	err = nci_spi_send(drv_data->nci_spi, &drv_data->handshake_completion,
 			   skb);
-	if (err != 0) {
+	if (err)
 		nfc_err(priv->dev, "spi_send failed %d", err);
-		kfree_skb(skb);
-	}
+
 	return err;
 }