From: Ohad Ben-Cohen <ohad@wizery.com>
Date: Wed, 1 Jun 2011 16:39:46 +0000 (-0300)
Subject: [media] media: omap3isp: fix a potential NULL deref
X-Git-Tag: v3.0-rc7~2^2~31
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ca4186f06fecbf2b692a42cdea54b7ef23b2496c;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git

[media] media: omap3isp: fix a potential NULL deref

Fix a potential NULL pointer dereference by skipping registration of
external entities in case none are provided.

This is useful at least when testing mere memory-to-memory scenarios.

Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

diff --git a/drivers/media/video/omap3isp/isp.c b/drivers/media/video/omap3isp/isp.c
index c9fd04e..94b6ed8 100644
--- a/drivers/media/video/omap3isp/isp.c
+++ b/drivers/media/video/omap3isp/isp.c
@@ -1748,7 +1748,7 @@ static int isp_register_entities(struct isp_device *isp)
 		goto done;
 
 	/* Register external entities */
-	for (subdevs = pdata->subdevs; subdevs->subdevs; ++subdevs) {
+	for (subdevs = pdata->subdevs; subdevs && subdevs->subdevs; ++subdevs) {
 		struct v4l2_subdev *sensor;
 		struct media_entity *input;
 		unsigned int flags;