From: Hou Qi <qi.hou@nxp.com>
Date: Fri, 22 Sep 2023 07:57:28 +0000 (+0900)
Subject: v4l2videodec: Correctly free caps to avoid memory leak
X-Git-Tag: 1.22.7~57
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ca2f7a4254030ce22a490876f6426ae42dac90f2;hp=c7eed33e22b813c818f61271f0a810bbd1695de2;p=platform%2Fupstream%2Fgstreamer.git

v4l2videodec: Correctly free caps to avoid memory leak

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5388>
---

diff --git a/subprojects/gst-plugins-good/sys/v4l2/gstv4l2videodec.c b/subprojects/gst-plugins-good/sys/v4l2/gstv4l2videodec.c
index 3019a09..c7f39dd 100644
--- a/subprojects/gst-plugins-good/sys/v4l2/gstv4l2videodec.c
+++ b/subprojects/gst-plugins-good/sys/v4l2/gstv4l2videodec.c
@@ -465,10 +465,8 @@ gst_v4l2_video_dec_negotiate (GstVideoDecoder * decoder)
   /* Prefer the acquired caps over anything suggested downstream, this ensure
    * that we preserves the bit depth, as we don't have any fancy fixation
    * process */
-  if (gst_caps_is_subset (acquired_caps, caps)) {
-    gst_caps_unref (acquired_caps);
+  if (gst_caps_is_subset (acquired_caps, caps))
     goto use_acquired_caps;
-  }
 
   /* Fixate pixel format */
   caps = gst_caps_fixate (caps);
@@ -482,6 +480,7 @@ gst_v4l2_video_dec_negotiate (GstVideoDecoder * decoder)
     gst_v4l2_clear_error (&error);
 
 use_acquired_caps:
+  gst_caps_unref (acquired_caps);
   gst_caps_unref (caps);
 
   /* catch possible bogus driver that don't enumerate the format it actually