From: Dan Carpenter Date: Tue, 1 Apr 2014 13:38:44 +0000 (+0300) Subject: net: sxgbe: sxgbe_mdio_register() frees the bus X-Git-Tag: v4.14-rc1~7785^2~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ca231f838870e9c83aaf2c0eff136150cd97b412;p=platform%2Fkernel%2Flinux-rpi.git net: sxgbe: sxgbe_mdio_register() frees the bus "err" is always zero at this point so we always unregister and free the mdio_bus before returning success. This seems like left over code and I have deleted it. Fixes: 1edb9ca69e8a ('net: sxgbe: add basic framework for Samsung 10Gb ethernet driver') Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_mdio.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_mdio.c index b0eb0a2..01af2cb 100644 --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_mdio.c +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_mdio.c @@ -219,13 +219,6 @@ int sxgbe_mdio_register(struct net_device *ndev) } } - if (!err) { - netdev_err(ndev, "PHY not found\n"); - mdiobus_unregister(mdio_bus); - mdiobus_free(mdio_bus); - goto mdiobus_err; - } - priv->mii = mdio_bus; return 0;