From: Zhen Lei Date: Tue, 11 May 2021 09:29:23 +0000 (+0800) Subject: drm/vc4: Remove redundant error printing in vc4_ioremap_regs() X-Git-Tag: accepted/tizen/unified/20230118.172025~6402^2~28^2~421 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ca0b0c1f4a2aa281bf68668e00400e2bfbdaff0e;p=platform%2Fkernel%2Flinux-rpi.git drm/vc4: Remove redundant error printing in vc4_ioremap_regs() When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot Signed-off-by: Zhen Lei Signed-off-by: Maxime Ripard Link: https://patchwork.freedesktop.org/patch/msgid/20210511092923.4617-1-thunder.leizhen@huawei.com --- diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index 68ac0e7..9eff45b 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.c +++ b/drivers/gpu/drm/vc4/vc4_drv.c @@ -57,10 +57,8 @@ void __iomem *vc4_ioremap_regs(struct platform_device *dev, int index) res = platform_get_resource(dev, IORESOURCE_MEM, index); map = devm_ioremap_resource(&dev->dev, res); - if (IS_ERR(map)) { - DRM_ERROR("Failed to map registers: %ld\n", PTR_ERR(map)); + if (IS_ERR(map)) return map; - } return map; }